address @dirkgr comments

Dockerfile

@@ -30,11 +30,11 @@ COPY allennlp/version.py allennlp/version.py
 COPY setup.py .
 RUN touch allennlp/__init__.py \
     && touch README.md \
-    && pip install --no-cache-dir -e .[vision]
+    && pip install --no-cache-dir -e .
 
 # Now add the full package source and re-install just the package.
 COPY allennlp allennlp
-RUN pip install --no-cache-dir --no-deps -e .[vision]
+RUN pip install --no-cache-dir --no-deps -e .
 
 WORKDIR /app/
 

Dockerfile.test

@@ -30,10 +30,10 @@ COPY setup.py .
 COPY dev-requirements.txt .
 RUN touch allennlp/__init__.py \
     && touch README.md \
-    && pip install --no-cache-dir -e .[vision] -r dev-requirements.txt
+    && pip install --no-cache-dir -e . -r dev-requirements.txt
 
 # Now add the full package source and re-install just the package.
 COPY . .
-RUN pip install --no-cache-dir --no-deps -e .[vision]
+RUN pip install --no-cache-dir --no-deps -e .
 
 ENTRYPOINT ["make"]

Makefile

@@ -85,7 +85,7 @@ install :
 	# Due to a weird thing with pip, we may need egg-info before running `pip install -e`.
 	# See https://github.com/pypa/pip/issues/4537.
 	python setup.py install_egg_info
-	pip install --upgrade --upgrade-strategy eager -e .[vision] -r dev-requirements.txt
+	pip install --upgrade --upgrade-strategy eager -e . -r dev-requirements.txt
 
 #
 # Documention helpers.

README.md

@@ -151,8 +151,7 @@ to distribute as a plugin, see the [subcommand API docs](https://docs.allennlp.o
 AllenNLP requires Python 3.6.1 or later and [PyTorch](https://pytorch.org/).
 It's recommended that you install the PyTorch ecosystem **before** installing AllenNLP by following the instructions on [pytorch.org](https://pytorch.org/).
 
-The preferred way to install AllenNLP is via `pip`. Just run `pip install allennlp`. Or, if you want the vision
-features of the library, run `pip install allennlp[vision]`.
+The preferred way to install AllenNLP is via `pip`. Just run `pip install allennlp`.
 
 > ⚠️ If you're using Python 3.7 or greater, you should ensure that you don't have the PyPI version of `dataclasses` installed after running the above command, as this could cause issues on certain platforms. You can quickly check this by running `pip freeze | grep dataclasses`. If you see something like `dataclasses=0.6` in the output, then just run `pip uninstall -y dataclasses`.
 

allennlp/common/util.py

@@ -342,17 +342,7 @@ def import_module_and_submodules(package_name: str) -> None:
     # the end won't hurt anything.
     with push_python_path("."):
         # Import at top level
-        try:
-            module = importlib.import_module(package_name)
-        except ImportError as err:
-            if err.name in {"torchvision"}:
-                logger.warning(
-                    "vision module '%s' is unavailable since '%s' is not installed",
-                    package_name,
-                    err.name,
-                )
-                return None
-            raise
+        module = importlib.import_module(package_name)
         path = getattr(module, "__path__", [])
         path_string = "" if not path else path[0]
 

allennlp/data/__init__.py

@@ -16,9 +16,4 @@
 from allennlp.data.tokenizers.tokenizer import Tokenizer
 from allennlp.data.vocabulary import Vocabulary
 from allennlp.data.batch import Batch
-
-try:
-    from allennlp.data.image_loader import ImageLoader, TorchImageLoader
-except ModuleNotFoundError as err:
-    if err.name not in {"torchvision"}:
-        raise
+from allennlp.data.image_loader import ImageLoader, TorchImageLoader

allennlp/data/dataset_readers/__init__.py

@@ -18,12 +18,7 @@
 from allennlp.data.dataset_readers.sequence_tagging import SequenceTaggingDatasetReader
 from allennlp.data.dataset_readers.sharded_dataset_reader import ShardedDatasetReader
 from allennlp.data.dataset_readers.text_classification_json import TextClassificationJsonReader
-
-try:
-    from allennlp.data.dataset_readers.vision_reader import VisionReader
-    from allennlp.data.dataset_readers.vqav2 import VQAv2Reader
-    from allennlp.data.dataset_readers.visual_entailment import VisualEntailmentReader
-    from allennlp.data.dataset_readers.gqa import GQAReader
-except ModuleNotFoundError as err:
-    if err.name not in {"torchvision"}:
-        raise
+from allennlp.data.dataset_readers.vision_reader import VisionReader
+from allennlp.data.dataset_readers.vqav2 import VQAv2Reader
+from allennlp.data.dataset_readers.visual_entailment import VisualEntailmentReader
+from allennlp.data.dataset_readers.gqa import GQAReader

allennlp/data/dataset_readers/gqa.py

@@ -153,7 +153,7 @@ def text_to_instance(
             "box_features": ArrayField(features),
             "box_coordinates": ArrayField(coords),
             "box_mask": ArrayField(
-                features.new_full((features.shape[0],), True, dtype=torch.bool),
+                features.new_ones((features.shape[0],), dtype=torch.bool),
                 padding_value=False,
                 dtype=torch.bool,
             ),

allennlp/data/dataset_readers/visual_entailment.py

@@ -74,7 +74,7 @@ def text_to_instance(
             fields["box_features"] = ArrayField(features)
             fields["box_coordinates"] = ArrayField(coords)
             fields["box_mask"] = ArrayField(
-                features.new_full((features.shape[0],), True, dtype=torch.bool),
+                features.new_ones((features.shape[0],), dtype=torch.bool),
                 padding_value=False,
                 dtype=torch.bool,
             )

allennlp/data/dataset_readers/vqav2.py

@@ -513,7 +513,7 @@ def text_to_instance(
             fields["box_features"] = ArrayField(features)
             fields["box_coordinates"] = ArrayField(coords)
             fields["box_mask"] = ArrayField(
-                features.new_full((features.shape[0],), True, dtype=torch.bool),
+                features.new_ones((features.shape[0],), dtype=torch.bool),
                 padding_value=False,
                 dtype=torch.bool,
             )

allennlp/data/image_loader.py

@@ -48,6 +48,7 @@ class ImageLoader(Registrable):
 
     def __init__(
         self,
+        *,
         size_divisibility: int = 0,
         pad_value: float = 0.0,
         device: Union[str, torch.device] = "cpu",
@@ -146,6 +147,7 @@ class TorchImageLoader(ImageLoader):
 
     def __init__(
         self,
+        *,
         image_backend: str = None,
         resize: bool = True,
         normalize: bool = True,
@@ -154,7 +156,7 @@ def __init__(
         pixel_mean: Tuple[float, float, float] = (0.485, 0.456, 0.406),
         pixel_std: Tuple[float, float, float] = (0.229, 0.224, 0.225),
         size_divisibility: int = 32,
-        **kwargs
+        **kwargs,
     ) -> None:
         super().__init__(size_divisibility=size_divisibility, **kwargs)
         if image_backend is not None:

allennlp/modules/vision/region_detector.py

@@ -108,6 +108,7 @@ class FasterRcnnRegionDetector(RegionDetector):
 
     def __init__(
         self,
+        *,
         box_score_thresh: float = 0.05,
         box_nms_thresh: float = 0.5,
         max_boxes_per_image: int = 100,

setup.py

@@ -51,6 +51,7 @@
     ),
     install_requires=[
         "torch>=1.6.0,<1.8.0",
+        "torchvision>=0.8.1,<0.9.0",
         "jsonnet>=0.10.0 ; sys.platform != 'win32'",
         "overrides==3.1.0",
         "nltk",
@@ -71,11 +72,6 @@
         "lmdb",
         "more-itertools",
     ],
-    extras_require={
-        "vision": [
-            "torchvision>=0.8.1,<0.9.0",
-        ],
-    },
     entry_points={"console_scripts": ["allennlp=allennlp.__main__:run"]},
     include_package_data=True,
     python_requires=">=3.6.1",