This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix tqdm logging into multiple files with allennlp-optuna #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagiaSN
changed the title
ArjunSubramonian
requested review from
dirkgr,
ArjunSubramonian and
epwalsh
and removed request for
dirkgr
|
This PR looks great so far! I've added @epwalsh as well for a second pair of eyes. It would be great to have a test that fails without the bug fix. |
Fine, I have added a test |
Abhishek-P
pushed a commit
to Abhishek-P/allennlp
that referenced
this pull request
Aug 11, 2021
* Fix tqdm logging into multiple files with allennlp-optuna * Update changelog * Add unittest for resetting tqdm logger handlers Co-authored-by: Pete <petew@allenai.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5234.
Changes proposed in this pull request:
tqdmlogging into multiple files withallennlp-optuna.Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting
codecov/patchreports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.