Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Ensure all relevant allennlp submodules are imported with import_plugins() #5246

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Ensure all relevant allennlp submodules are imported with import_plugins() #5246

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcee5cc
ensure allennlp is a default plugin
epwalsh Jun 7, 2021
c551db8
fix logging issue
epwalsh Jun 7, 2021
e807008
fixes
epwalsh Jun 7, 2021
2a71ca2
actually fix
epwalsh Jun 7, 2021
f753d97
List -> Set
epwalsh Jun 7, 2021
06dda2a
oops, fix
epwalsh Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ensure allennlp is a default plugin
  • Loading branch information
@epwalsh
epwalsh committed Jun 7, 2021
commit dcee5cc4807681b38d21dbd353a9da52ea074bfd
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Fixed Broken link in `allennlp.fairness.fairness_metrics.Separation` docs
- `allennlp` is now treated as a default plugin itself to ensure that `allennlp.common.plugins.import_plugins()`
imports all submodules of `allennlp`.


## [v2.5.0](https://github.com/allenai/allennlp/releases/tag/v2.5.0) - 2021-06-03
Expand Down
2 changes: 1 addition & 1 deletion allennlp/common/plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
The global plugins file will be found here.
"""

DEFAULT_PLUGINS = ("allennlp_models", "allennlp_semparse", "allennlp_server")
DEFAULT_PLUGINS = ("allennlp", "allennlp_models", "allennlp_semparse", "allennlp_server")
"""
Default plugins do not need to be declared in a plugins file. They will always
be imported when they are installed in the current Python environment.
Expand Down