This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Transformer toolkit updates #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshitaB
suggested changes
Jun 17, 2021
| super().__init__(hidden_size, intermediate_size, activation, pool=True) | ||
|
|
||
| @classmethod | ||
| def _get_input_arguments( |
There was a problem hiding this comment.
We don't require this method any longer. from_config takes care of what we need.
AkshitaB
approved these changes
Jun 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is spun out of some of the Tango stuff.
From the changelog:
TransformerEmbeddingsnow takes, but ignores, a parameter for the attention mask. This is needed for compatibility with some other modules that get called the same way and use the mask.TransformerPoolercan now be instantiated from a pretrained transformer module, just like the other modules in the transformer toolkit.