Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix Checkpointer cleaner regex on Windows #5361

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Fix Checkpointer cleaner regex on Windows #5361

merged 4 commits into from
Aug 27, 2021

Conversation

bratao
Copy link
Contributor

@bratao bratao commented Aug 17, 2021

This fixes the Checkpointer cleaner regex on Windows

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bratao!

@epwalsh epwalsh enabled auto-merge (squash) August 27, 2021 18:26
@epwalsh epwalsh merged commit 6355f07 into allenai:main Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants