This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Dataset remix #5372
Merged
Dataset remix #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work yet. I'm still working on supporting classes.
AkshitaB
reviewed
Aug 23, 2021
| self, input: DatasetDict, new_splits: Dict[str, str], keep_old_splits: bool = True | ||
| ) -> DatasetDict: | ||
| def get_slice(split_name: str) -> Sequence[Any]: | ||
| slice_match = re.match(r"(.*)\[([0123456789:]*)]", split_name) |
There was a problem hiding this comment.
This won't work for something like train[:50000] + dev[:10000]. Is it supposed to?
There was a problem hiding this comment.
Yes, it will work. This function is only called on the parts after .split("+").
There was a problem hiding this comment.
Ok I see, and train[:50000] in that case is interpreted as it should be?
There was a problem hiding this comment.
Yes. It supports full Python slice syntax on line 98. In condensed form, it does slice(*match.split(":")).
AkshitaB
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #5344 being merged first.
It adds a step that can remix an existing dataset in a flexible way. You give it a
Dict[str, str]like this:That means, from the original dataset, take the whole "train" split, combine it with the first 10000 instances of the "dev" split, and call that the new "train" split. Also, take everything after the first 10000 instances of the "dev" split, and call that the "validation" split.
Also, there are some urgent Tango fixes in here.