Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Enforce reading in utf-8 encoding #5476

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Enforce reading in utf-8 encoding #5476

merged 6 commits into from
Dec 1, 2021

Conversation

AkshitaB
Copy link
Contributor

Potentially fixes #5466

@AkshitaB AkshitaB requested a review from dirkgr November 19, 2021 23:45
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Potentially"?

@AkshitaB
Copy link
Contributor Author

"Potentially"?

Since we don't check with a windows machine.

@dirkgr
Copy link
Member

dirkgr commented Dec 1, 2021

I just checked with a Windows machine. Works like a charm!

Does that mean my gaming computer is now tax deductible? 😛

@dirkgr dirkgr enabled auto-merge (squash) December 1, 2021 01:44
@dirkgr dirkgr merged commit c557d51 into main Dec 1, 2021
@dirkgr dirkgr deleted the fix-setup-encoding branch December 1, 2021 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to install from source on Windows 10 using conda environment
2 participants