Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix should validate callback train end #5542

Merged

Conversation

JohnGiorgi
Copy link
Contributor

Addresses another bug in #5534. Sorry my original PR had so many bugs in it!

Changes proposed in this pull request:

The ShouldValidateCallback merged in #5534 was missing the method on_end. This caused validation to never occur at the end of training, even if the final epoch satisfied validation_start and validation_interval. I added an additional check to the test for this scenario.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@AkshitaB AkshitaB merged commit 2deacfe into allenai:main Jan 27, 2022
@JohnGiorgi JohnGiorgi deleted the fix_should_validate_callback_train_End branch January 27, 2022 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants