Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Relax requirements on protobuf to allow for minor changes and patches. #5694

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Relax requirements on protobuf to allow for minor changes and patches. #5694

merged 1 commit into from
Aug 17, 2022

Conversation

lewisbails
Copy link
Contributor

@lewisbails lewisbails commented Jul 22, 2022

Changes proposed in this pull request:

  • Relaxed protobuf requirement from protobuf==3.20.0 to protobuf>=3.20.0,<4.0.0, to allow for security patch 3.20.1 patch on protobuf

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@dirkgr
Copy link
Member

dirkgr commented Aug 17, 2022

Thank you!

@dirkgr dirkgr merged commit c6b248f into allenai:main Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants