This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Constituency Parser Predictor and tests #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgrus
approved these changes
Feb 22, 2018
| predictor = Predictor.from_archive(archive, 'constituency-parser') | ||
| result = predictor.predict_json(inputs) | ||
|
|
||
| assert len(result["spans"]) == 21 |
There was a problem hiding this comment.
might be nice to add comment why this is the expected result
| assert result["sentence"] == ["What", "a", "great", "test", "sentence", "."] | ||
| assert isinstance(result["trees"], str) | ||
|
|
||
| for class_distribution in result["class_probabilities"]: |
There was a problem hiding this comment.
do you want to add an assert for len(class_probabilities) like you have in the other test? this would pass if it were empty for some reason.
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
* add constituency predictor, clean up some span padding in decode * regenerate test fixtures, address some regressions * batch test * fix up test, docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is smaller than it looks because I had to regenerate the fixtures