This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Constituency js #916
Merged
Constituency js #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 22, 2018 15:42
joelgrus
approved these changes
Feb 23, 2018
| @@ -47,7 +47,8 @@ def test_read_from_file(self): | |||
| "VP(TO to)(VP(VB be)(ADJP(JJ fair)(PP(TO to)(NP(JJ other)(NNS " | |||
| "bidders))))))))))))))(. .)))") | |||
|
|
|||
| assert fields["gold_tree"].metadata == gold_tree | |||
| assert fields["metadata"].metadata["gold_tree"] == gold_tree | |||
| assert fields["metadata"].metadata["tokens"] == tokens | |||
There was a problem hiding this comment.
this always feels clunky to me, I wonder if MetadataField should implement __getitem__? (not in this PR of course, just in general)
There was a problem hiding this comment.
We could do this for all of our fields, e.g. for token in TextField etc, etc. I'm a fan
There was a problem hiding this comment.
What does for token in TextField return, and when is it called?
For the MetadataField, it was originally a hack to get something working for BiDAF. There is definitely room to improve it.
There was a problem hiding this comment.
it would be equivalent to that list comprehension (or probably returning Tokens). Maybe it's less useful because it's unclear what it would return, but it would make it much cleaner.
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
* 'working' constituency parsing demo * wire the actual sentence through model, predictor and dataset reader * 90% working hierplane vis * tidy up, remove sentence lengths from return dict * clean up some js, remove spans from the demo * better description of the model * add explicit hierplane tree in test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo looks like this:
(We've hit maximum text wrapping capacity on a mac on the demo - we're going to need a "Select a demo model" page pretty soon.... it could look like this but for deep learning models)