Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 28MB GIF file with a 3MB video #20

Merged
merged 4 commits into from
Aug 2, 2018
Merged

Replace 28MB GIF file with a 3MB video #20

merged 4 commits into from
Aug 2, 2018

Conversation

niutech
Copy link
Contributor

@niutech niutech commented Aug 2, 2018

Please save users' data plans and loading times!

@alokmenghrajani
Copy link
Owner

alokmenghrajani commented Aug 2, 2018

Sure. But I'd rather you include the file in the repo (i.e. add it to the /files/2018/bootable_cd_retro_game_tweet/ folder and remove the existing gif).

Also, make sure you encode the full gif (not just the first 15 seconds).

@alokmenghrajani
Copy link
Owner

Now that I think about it, you might want to explore doing this in a jekyll plugin? You'll be able to save a ton more bandwidth, across many sites on the web, rather than just converting this one file.

@alokmenghrajani
Copy link
Owner

You still have to update the html to use the file you uploaded. Also worth deleting the old gif, since it won't be referenced anywhere.

@alokmenghrajani alokmenghrajani changed the title Replace 28MB GIF file with a 1MB video Replace 28MB GIF file with a 3MB video Aug 2, 2018
@niutech
Copy link
Contributor Author

niutech commented Aug 2, 2018

I've done it right now.
The old GIF is provided as a fallback for browsers not supporting HTML video in MP4 format.
Sorry, I don't know how to make Jekyll plugins auto-converting GIF files to MP4.

@alokmenghrajani
Copy link
Owner

👍

@alokmenghrajani alokmenghrajani merged commit b7a5922 into alokmenghrajani:master Aug 2, 2018
@niutech niutech deleted the patch-1 branch August 3, 2018 01:19
@niutech
Copy link
Contributor Author

niutech commented Aug 3, 2018

It is weird, but the GIF fallback is still being downloaded despite the MP4 video. I will make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants