PP-1809 Downgrade dropwizard-metrics to 3.1.2 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dropwizard 1.0.6 brings in metrics version 3.1.2. We were explicitly pulling in version 3.2.0, which changed the way metrics paths are sanitised. See dropwizard/metrics#1098. - By not explicitly pulling in metrics-core (and letting dropwizard decide on which version to use) and downgrading graphite-metrics, we will go back to a well tested version - The version of metrics 3.2.1 will be pulled in by the next version of dropwizard. This should be safe to use, as the bug which broke our metrics has been fixed. Still, would advise some caution when upgrading dropwizard again
|
There were no errors, go have a cup of coffee... |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly pulling in version 3.2.0, which changed the way
metrics paths are sanitised.
See To be honest I disagree with the way we do sanitizing here and would … dropwizard/metrics#1098.
decide on which version to use) and downgrading graphite-metrics,
we will go back to a well tested version
of dropwizard. This should be safe to use, as the bug which broke
our metrics has been fixed. Still, would advise some caution
when upgrading dropwizard again