Skip to content

Commit

Permalink
PP-1809 Downgrade dropwizard-metrics to 3.1.2
Browse files Browse the repository at this point in the history
- Dropwizard 1.0.6 brings in metrics version 3.1.2. We were
  explicitly pulling in version 3.2.0, which changed the way
  metrics paths are sanitised.
  See dropwizard/metrics#1098.
- By not explicitly pulling in metrics-core (and letting dropwizard
  decide on which version to use) and downgrading graphite-metrics,
  we will go back to a well tested version
- The version of metrics 3.2.1 will be pulled in by the next version
  of dropwizard. This should be safe to use, as the bug which broke
  our metrics has been fixed. Still, would advise some caution
  when upgrading dropwizard again
  • Loading branch information
Silvia Mandala committed Mar 16, 2017
1 parent 08557e9 commit 6b5afc2
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,10 @@
<artifactId>commons-codec</artifactId>
<version>1.10</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-core</artifactId>
<version>3.2.0</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-graphite</artifactId>
<version>3.2.0</version>
<version>3.1.2</version>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.core</groupId>
Expand Down

0 comments on commit 6b5afc2

Please sign in to comment.