Skip to content

Commit

Permalink
Fix: (org-ql-view--format-element) Avoid unlinkifying links
Browse files Browse the repository at this point in the history
I don't fully understand why this is the correct fix, because I don't
know where the raw heading text is being linkified (it seems like the
:raw-value property should be the unlinkified text), but this seems to
work correctly now.  If it turns out to break something else, we'll
find out and fix it.

Fixes #282.

Reported-by: Jacob Boxerman <https://github.com/jakebox>
  • Loading branch information
alphapapa committed Jan 4, 2024
1 parent 8e9a8fe commit 529e058
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 37 deletions.
1 change: 1 addition & 0 deletions README.org
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,7 @@ Simple links may also be written manually in either sexp or non-sexp form, like:
*Fixes*

+ Command ~org-ql-find~ widens the buffer before going to the selected entry.
+ In ~org-ql-view~ buffers, links in headings remain clickable links. (Fixes [[https://github.com/alphapapa/org-ql/issues/282][#282]]. Thanks to [[https://github.com/jakebox][Jacob Boxerman]] for reporting.)

** 0.8

Expand Down
3 changes: 1 addition & 2 deletions org-ql-view.el
Original file line number Diff line number Diff line change
Expand Up @@ -869,8 +869,7 @@ return an empty string."
;; Adding the relative due date property should probably be done explicitly and separately
;; (which would also make it easier to do it independently of faces, etc).
(title (--> (org-ql-view--add-faces element)
(org-element-property :raw-value it)
(org-link-display-format it)))
(org-element-property :raw-value it)))
(todo-keyword (-some--> (org-element-property :todo-keyword element)
(org-ql-view--add-todo-face it)))
(tag-list (if org-use-tag-inheritance
Expand Down
74 changes: 39 additions & 35 deletions org-ql.info
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,10 @@ File: README.info, Node: 081-pre, Next: 08, Up: Changelog

• Command ‘org-ql-find’ widens the buffer before going to the
selected entry.
• In ‘org-ql-view’ buffers, links in headings remain clickable links.
(Fixes #282 (https://github.com/alphapapa/org-ql/issues/282).
Thanks to Jacob Boxerman (https://github.com/jakebox) for
reporting.)


File: README.info, Node: 08, Next: 074, Prev: 081-pre, Up: Changelog
Expand Down Expand Up @@ -1919,41 +1923,41 @@ Node: Links38827
Node: Tips39514
Node: Changelog39838
Node: 081-pre40676
Node: 0840871
Node: 07443599
Node: 07343822
Node: 07244554
Node: 07145473
Node: 0746282
Node: 06349206
Node: 06249737
Node: 06150042
Node: 0650612
Node: 05253668
Node: 05153970
Node: 0554395
Node: 04955926
Node: 04856208
Node: 04756557
Node: 04656966
Node: 04557374
Node: 04457735
Node: 04358094
Node: 04258297
Node: 04158458
Node: 0458705
Node: 03262806
Node: 03163209
Node: 0363406
Node: 02366706
Node: 02266940
Node: 02167220
Node: 0267425
Node: 0171503
Node: Notes71604
Node: Comparison with Org Agenda searches71766
Node: org-sidebar72655
Node: License72934
Node: 0841097
Node: 07443825
Node: 07344048
Node: 07244780
Node: 07145699
Node: 0746508
Node: 06349432
Node: 06249963
Node: 06150268
Node: 0650838
Node: 05253894
Node: 05154196
Node: 0554621
Node: 04956152
Node: 04856434
Node: 04756783
Node: 04657192
Node: 04557600
Node: 04457961
Node: 04358320
Node: 04258523
Node: 04158684
Node: 0458931
Node: 03263032
Node: 03163435
Node: 0363632
Node: 02366932
Node: 02267166
Node: 02167446
Node: 0267651
Node: 0171729
Node: Notes71830
Node: Comparison with Org Agenda searches71992
Node: org-sidebar72881
Node: License73160

End Tag Table

Expand Down

0 comments on commit 529e058

Please sign in to comment.