This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Fix error reporting from custom transpilation passes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
airwoodix
force-pushed
the
test-circuit-sampling
branch
from
387f771
to
ad6f5df
Compare
wilfried-huss
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wrap the transformation functions of the custom transpilation passes such that any error is reported as
TranspilerError(a subclass ofQiskitError).This increases the compliance of the custom transpilation passes with the rest of the Qiskit infrastructure, in particular the legacy
qiskit.opflowtools.Details and comments
qiskit.opflow.CircuitSamplertool is able to deal with failures of the transpiler for unbound parametric circuits by delaying transpilation after the parameters are bound. This is unfortunately not the case for the newBackendSampler.