-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging dev branch 3.0.4 #3504
Merged
Merged
Merging dev branch 3.0.4 #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use unwrap function in "fullpage - destroy all" and in "scrolloverflow - destroy"; Unwrap function: keep existing DOM objects (instead of recreating them using innerHTML) to save all event listeners attached to them
Bugfix: loss attached events on unwrapping
Add conditional statement before remove eventListener
…esent but not used
Fix for issue #3489: Broken link on documentation :)
-Fixed bug: Direction on afterLoad Event Undefined when not using onLeave #3480
Updated link for IScroll
Restrict NodeList for "isLast" index comparison to child elements of parent node
Fix "isLast" issue #3471
Fix for issue #3489: Broken link on documentation
Repository owner
deleted a comment
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data-anchor
attributes stayed in DOM ondestroy('all')
scrollOverflow
causing maximum call stack size exceeded in certain casesreact-fullpage/38destroy('all')
showing error when scrollOverflow file present but not useddirection
isundefined
inafterLoad
Event Direction on afterLoad Event Undefined #3480isLast
nevertrue
inafterSlideLoad
&onSlideLeave
callbacks when having multiple sections with slides "isLast" is never true in afterSlideLoad and onSlideLeave callbacks when there are multiple sections with slides on the page #3471 thanks to @i22thasetAllowScrolling
not working inafterLoad
setAllowScrolling not working as expected upon page load inafterLoad
#3490paddingTop
&scrollOverflow
&verticalCentered
Padding Issue with ScrollOverflow #3335 Vertical Align Middle Alignment Issue on Scroll Overflow with Padding Top #3484normalScrollElements
requires a 1st touch in touch screens normalScrollElements requires a 1st touch in touch screens #3481deepExtend
package.json
fp-auto-height-responsive
demo Link to fp-auto-height-responsive demo in documentation is broken #3483