these random_double()'s are not so random...

alysssssa · May 1, 2023 · 023bc64 · 023bc64
1 parent 0aae8b3
commit 023bc64
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/raytracer/main.cpp b/raytracer/main.cpp
@@ -87,7 +87,7 @@ hittable_list random_scene() {
     auto material3 = make_shared<metal>(colour(0.7, 0.6, 0.5), 0.0);
     world.add(make_shared<sphere>(point3(4,1,0), 1.0, material3));
 
-    return hittable_list(make_shared<bvh_node>(world, 0.0, 1.0));
+    return {make_shared<bvh_node>(world, 0.0, 1.0)};
 }
 
 int main() {

diff --git a/raytracer/raytracer.h b/raytracer/raytracer.h
@@ -6,7 +6,7 @@
 #include <limits>
 #include <memory>
 #include <cstdlib>
-//#include <random>
+#include <random>
 
 using std::shared_ptr;
 using std::make_shared;
@@ -21,24 +21,24 @@ inline double degrees_to_radians(double degrees) {
     return degrees * pi / 180.0;
 }
 
+// alternative random number generator
+//inline double random_double() {
+//    // random number in [0,1)
+//    return rand() / (RAND_MAX + 1.0);
+//}
+
 inline double random_double() {
     // random number in [0,1)
-    return rand() / (RAND_MAX + 1.0);
+    static std::uniform_real_distribution<double> distribution(0.0,1.0);
+    static std::mt19937 generator;
+    return distribution(generator);
 }
 
 inline double random_double(double min, double max) {
     // random number in [min,max)
     return min + (max-min)*random_double();
 }
 
-// alternative random number generator
-//inline double random_double2() {
-//    // random number in [0,1)
-//    static std::uniform_real_distribution<double> distribution(0.0,1.0);
-//    static std::mt19937 generator;
-//    return distribution(generator);
-//}
-
 inline int random_int(int min, int max) {
     // random integer in [min,max]
     return static_cast<int>(random_double(min, max+1));