Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes conversion work also on the iOS #4

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Makes conversion work also on the iOS #4

merged 5 commits into from
Dec 21, 2020

Conversation

bazinac
Copy link
Contributor

@bazinac bazinac commented Sep 18, 2020

No description provided.

@am15h
Copy link
Owner

am15h commented Oct 1, 2020

@bazinac Thanks a lot for your pull request.

@tomk9
Copy link
Contributor

tomk9 commented Dec 17, 2020 •
edited
Loading

@bazinac I tested your PR and bounding boxes are shifted on iOS.

Android iOS
Screenshot_20201217-190806 IMG_0564

@tomk9
Copy link
Contributor

tomk9 commented Dec 19, 2020

Probably my problem with iOS is caused by this statement

object_detection_flutter/lib/ui/camera_view.dart

Line 92 in a5281e1

CameraViewSingleton.ratio = screenSize.width / previewSize.width;

So it is not in the scope of PR. @am15h please merge this PR.

@am15h am15h merged commit 8186662 into am15h:master Dec 21, 2020
@am15h
Copy link
Owner

am15h commented Dec 21, 2020

Thanks, @bazinac, and @tomk9 for your kind efforts. Very sorry for the delay, I was unable to get my hands on an iOS device for testing this.

The shifting of bounding boxes needs to be investigated separately.

@am15h am15h linked an issue Dec 21, 2020 that may be closed by this pull request
Example not running on iOS, due to issue with ImageUtils.convertYUV420ToImage #3
Closed
@mlopez0 mlopez0 mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomk9 tomk9 tomk9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example not running on iOS, due to issue with ImageUtils.convertYUV420ToImage
3 participants
@bazinac @am15h @tomk9