Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chain and ChainAsync #77

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Add Chain and ChainAsync #77

merged 4 commits into from
Jan 4, 2024

Conversation

amantinband
Copy link
Owner

No description provided.

@amantinband amantinband mentioned this pull request Jan 2, 2024
Closed
apfohl
apfohl approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@apfohl apfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one small thing to think about.

src/ErrorOrExtensions.cs Outdated Show resolved Hide resolved
apfohl
apfohl reviewed Jan 3, 2024
View reviewed changes
src/ErrorOrExtensions.cs Outdated Show resolved Hide resolved
amantinband
amantinband commented Jan 3, 2024
View reviewed changes
src/ErrorOr.cs Outdated Show resolved Hide resolved
apfohl
apfohl approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@apfohl apfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job.

@amantinband amantinband merged commit e2ee67f into main Jan 4, 2024
1 check passed
@amantinband amantinband deleted the feature/add-chain-and-chain-async branch January 4, 2024 08:01
@amantinband amantinband mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apfohl apfohl apfohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amantinband @apfohl