ErrorOr<TValue> and Error now behave like Value Objects #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements Equals and GetHashCode for the ErrorOr<TValue> struct so that a deep comparison with the errors list is performed (instead of the default reference equality comparison). I introduced Microsoft.Bcl.HashCode for .NET Standard 2.0 because I did not want to reinvent the wheel for the HashCode class. If we do not want this dependency then we should copy over the source code for .NET Standard 2.0. Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
This commit implements Equals and GetHashCode in the same way that the previous commit implemented it for ErrorOr<TValue>. Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #85 by explicitly implementing
EqualsandGetHashCodefor theErrorOr<TValue>andErrorrecord structs. In them, we perform a deep comparison for the errors list and metadata dictionary, respectively. I also include unit tests that cover these implementations.I introduced the runtime dependency Microsoft.Bcl.HashCode so that I can use the
HashCodestruct both in .NET Standard 2.0 and .NET 6. If we do not want this dependency for .NET Standard 2.0, we should copy over the source code ofHashCode- please let me know how you want to deal with this.I also introduced Nullable, but this is not a runtime dependency. It is simply there so that I can use the
MemberNotNullWhenAttributein .NET Standard 2.0, too. This helps Roslyn with tracking whether_valueor_errorsis null whenIsErrorswas called beforehand inErrorOr<TValue>.