Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #47
Description of changes:
Enables Explicit API mode. This requires us to be explicit about what is part of the API, and to be explicit about the return types of any public functions.
In most cases, it was obvious that the class/interface/val/fun should be public, but there are a few cases that I was not completely sure about.
typealias Annotations
-- appears to only be used internally, but another typealias (MetaContainer
) does already have confirmed external usage.IonElementException
constructors -- while the exceptions themselves should be public, should the constructors be public?In both cases, I have chosen to be conservative and label them as internal, but I'm definitely open to be convinced otherwise.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.