Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds browserslist integration for browserify grunt task #774

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Mar 28, 2024

Issue #773 :

Description of changes:

This PR fixes the issue of TypeError: Cannot convert a BigInt value to a number when importing browser bundle of ion-js.

Issue: This is a known issue with babel: babel/babel#13109. (this issues also has a suggested solution)

The fix lies in defining browserslist in package.json for @babel/preset-env. From the babel documentation:

By default @babel/preset-env will use browserslist config sources unless either the targets or ignoreBrowserslistConfig options are set.

Fix: Following the solution specified in babel/babel#13109, added browserslist in package.json. The list of compatible browsers is gathered from AWS SDK supported browsers.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@desaikd desaikd requested a review from zslayton March 28, 2024 23:33
@desaikd
Copy link
Contributor Author

desaikd commented Mar 28, 2024

ion-test-driver seems to fail for its first task of pip install and doesn't seem to be related to this change.

@desaikd desaikd merged commit fa47ca9 into amazon-ion:master Mar 29, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants