Increase verbosity #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get that this is some kind of a grey area due to the underlying race condition (files vanishing after they have been scanned). However, if we can't stat() a file it can have many different causes -- the file being vanished is just one of them. Since this tool is meant to help detect bit rot and corrupt file systems, I'd rather be informed about un-stat-able files.
I had a semi-corrupt encfs (which I detected, thanks to this tool!). A file was only partially readable. Somewhere in the middle, an IOError occured. Essentially, this is a corrupt file system -- which this tool is meant to help detect --, so this class of errors shouldn't be suppressed by "-q".
|
I like those changes, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't suppress some warnings when
verbosity == 0. See the individual commit messages on why I think this is a good idea. :-)