Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futuremice #504

Merged
merged 21 commits into from
Oct 31, 2022
Merged

Futuremice #504

merged 21 commits into from
Oct 31, 2022

Conversation

gerkovink
Copy link
Member

This PR introduces futuremice(), a straightforward and flexibly scaleable approach to parallelising the mice() algorithm. futuremice() is much more robust than parlmice() and works on any machine and any operating system. Furthermore, results with futuremice() are fully reproducible when the seed of the utilised furrr::future_map() process is fixed.

@stefvanbuuren stefvanbuuren merged commit 17b915c into amices:master Oct 31, 2022
@stefvanbuuren
Copy link
Member

Thom, Gerko,

Nice and elegant implementation of parallel imputation by future. Worked out-of-the-box. A great addition to mice().

I changed one dead link in the documentation to https://www.gerkovink.com/miceVignettes/futuremice/Vignette_futuremice.html. I don't know whether that is the correct version.

Should we start retiring parlmice()?

@gerkovink
Copy link
Member Author

I believe parlmice() is now superseded, but can be safely left for backwards compatibility of mice.

@thomvolker
Copy link
Member

Stef, thanks for merging. I agree with Gerko: I think parlmice can be superseded, but this information hasn't been added yet.

Apart from that, it would be good to look at commit 836e2f0. Do you remember that we discussed whether the post-processing command behaves as it should? In this commit, I made a change to the sampler such that post-processing behaves correctly I believe.

However, I later reversed this commit, because (1) it didn't belong in this PR anyway, and (2) it would be good to first double check what the behavior actually should be. I think the PR to the reversal is still floating around somewhere, but didn't make it to this PR. Perhaps you can reinstate the old state of the sampler.

Best,
Thom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants