Adds method that allows to identify a light optically #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht optically by id
|
@skroczek Thansk for this contribution. This is a nice addition to the library. I'd like to see a test covering your code. Other than that, looks awesome. |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 69.71% 73.42% +3.71%
==========================================
Files 5 5
Lines 1215 1430 +215
==========================================
+ Hits 847 1050 +203
- Misses 201 210 +9
- Partials 167 170 +3
Continue to review full report at Codecov.
|
|
@amimof thank you very much for your patience. I was very busy in the last months, so I could only now take care of the testing. I hope I have chosen the right tests. If I can improve something, I would be very happy about a feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while experimenting with the library that the function to identify a light is missing. It is very similar to the SetLightState method, but unfortunately the functionality cannot be achieved through it. I think it's mainly because the State always has the "On" property set when serializing to a json object.