-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consumer Proguard rules #174
Comments
Please use this
|
Cool, thanks! Still, do you think it is something that might be embedded into the library or do you want to keep rules out of it? |
Rules can be added as consumer proguard files: https://google.github.io/android-gradle-dsl/current/com.android.build.gradle.internal.dsl.BuildType.html#com.android.build.gradle.internal.dsl.BuildType:consumerProguardFiles |
@MiSikora We will add this to the library in the consumer Proguard rules in the new release. |
* Dependency versions bump: Android Gradle plugin 4.0.0-alpha06 Gradle 6.1-milestone-3 Kotlin 1.3.61 Fix font scale plugin dependencies * Add Android-Debug-Database consumer proguard rules Workaround for amitshekhariitbhu/Android-Debug-Database#174
Library should provide consumer Proguard rules. Our QA builds are shrinked but still use utilities such as this one. I didn't pinpoint which rules are required specifically and just use
-keep class com.amitshekhar.** { *; }
as the library never touches release builds. Without these rules inspection tool can only see the shape of the database but not its content.Is it something that you would consider adding into the library? If so, are these broad rules fine or do you think something more specific should be provided?
The text was updated successfully, but these errors were encountered: