Skip to content

Commit

Permalink
DXOC-828 Updated codegen (#220)
Browse files Browse the repository at this point in the history
  • Loading branch information
falconandy authored May 18, 2023
1 parent ab202d6 commit ba07cce
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion browser/typescript/v2/react-app/src/ampli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,8 @@ export class Ampli {
this.amplitude = options.client.instance;
} else if (apiKey) {
this.amplitude = amplitude.createInstance();
return this.amplitude.init(apiKey, undefined, { ...DefaultConfiguration, ...options.client?.configuration });
const configuration = (options.client && 'configuration' in options.client) ? options.client.configuration : {};
return this.amplitude.init(apiKey, undefined, { ...DefaultConfiguration, ...configuration });
} else {
console.error("ERROR: ampli.load() requires 'environment', 'client.apiKey', or 'client.instance'");
}
Expand Down
3 changes: 2 additions & 1 deletion node/typescript/v2/AmpliApp/src/ampli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,8 @@ export class Ampli {
this.amplitude = options.client.instance;
} else if (apiKey) {
this.amplitude = amplitude.createInstance();
return this.amplitude.init(apiKey, { ...DefaultConfiguration, ...options.client?.configuration });
const configuration = (options.client && 'configuration' in options.client) ? options.client.configuration : {};
return this.amplitude.init(apiKey, { ...DefaultConfiguration, ...configuration });
} else {
console.error("ERROR: ampli.load() requires 'environment', 'client.apiKey', or 'client.instance'");
}
Expand Down
1 change: 1 addition & 0 deletions react-native/typescript/v2/AmpliApp/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ function App() {

ampli.eventWithArrayTypes({
requiredBooleanArray: [true, false],
requiredEnumArray: ['enum1'],
requiredNumberArray: [1.2, 3, 4.56],
requiredObjectArray: [{'key-1': 'value-1'}, {'key-2': 'value-2'}],
requiredStringArray: ['string-1', 'string-2', 'string-3'],
Expand Down
3 changes: 2 additions & 1 deletion react-native/typescript/v2/AmpliApp/src/ampli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,8 @@ export class Ampli {
this.amplitude = options.client.instance;
} else if (apiKey) {
this.amplitude = amplitude.createInstance();
return this.amplitude.init(apiKey, undefined, { ...DefaultConfiguration, ...options.client?.configuration });
const configuration = (options.client && 'configuration' in options.client) ? options.client.configuration : {};
return this.amplitude.init(apiKey, undefined, { ...DefaultConfiguration, ...configuration });
} else {
console.error("ERROR: ampli.load() requires 'environment', 'client.apiKey', or 'client.instance'");
}
Expand Down

0 comments on commit ba07cce

Please sign in to comment.