Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-story-player: previous and next story buttons not visible in Safari #37211

Closed
fraserb99 opened this issue Dec 14, 2021 · 3 comments
Closed

Comments

@fraserb99
Copy link

Description

The buttons used for skipping between stories are not visible on Safari browsers. This includes macOS and iPadOS Safari.

Reproduction Steps

  1. Navigate to https://000615502.deployed.codepen.website with a browser that isn't Safari and open a story from the carousel. The skip buttons are correctly shown on either side of the story.
    image

  2. Navigate to https://000615502.deployed.codepen.website with Safari. The buttons are not visible. They are functional and can be clicked, they are just invisible
    image

Relevant Logs

No response

Browser(s) Affected

Safari

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

@processprocess
Copy link
Contributor

Hi Fraser. Thank you for filing this :)

It appears to be an issue specific to how Safari determines z space which is pretty interesting.
In Safari, translateZ will override z-index. Check out this thread on if you're curios.

This line appears to be the culprit.

Possible solutions:

  1. Remove the 1px translateZ on the active iframe, changing it to: transform: translate3d(0, 0, 0). This should be safe since the other iframe panels do not have a translateZ value.
  2. Add a 2px translateZ on the buttons (not recommended since it's a patch)

@stale
Copy link

stale bot commented Dec 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 24, 2022
@ychsieh
Copy link
Contributor

ychsieh commented Oct 2, 2023

Not reproducible

@stale stale bot removed the Stale Inactive for one year or more label Oct 2, 2023
@ychsieh ychsieh closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants