🐛 [Amp story player] Remove active iframe translateZ #37275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszylkowski
approved these changes
Dec 28, 2021
newmuis
reviewed
Feb 3, 2022
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| .i-amphtml-story-player-main-container iframe:nth-of-type(1), | |||
| .i-amphtml-story-player-main-container .story-player-iframe[i-amphtml-iframe-position="0"] { | |||
| transform: translate3d(0, 0, 1px); | |||
| transform: translate3d(0, 0, 0); | |||
| } | |||
There was a problem hiding this comment.
Do we know that the active iframe will still stay on top of others if we make this change (as that looks like the original intention of this code)? We should test both initial load and cross-browser cases
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Safari bug where translateZ overrides z-index, which is causing the previous and next story buttons to not be visible.
translateZ does not appear to be needed since translateX is being used to set position.
Context / Fixes #37211