Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support privateKeyString #4

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Conversation

FrikkieSnyman
Copy link
Contributor

Useful if you want to pass in the p8 key as a string (from a config or such) instead of storing it in a file.

@ananay
Copy link
Owner

ananay commented May 27, 2020

@FrikkieSnyman Could you please rebase this? Thanks!

@FrikkieSnyman
Copy link
Contributor Author

Just resolved the conflict - it was just a doc conflict

@sebastiangug
Copy link

Yeah can we integrate this please? It's not practical having to do it via fle in most production environments as that would mean commiting it to a repo in most cases.

@sebastiangug
Copy link

@FrikkieSnyman

Do you happen to have a module with this change that I could reference/download and use?

@FrikkieSnyman
Copy link
Contributor Author

@FrikkieSnyman
Copy link
Contributor Author

At that time we needed profile retrieval which I don't think this lib supported yet

@sebastiangug
Copy link

Thanks a bunch for all the help! I ended up integrating it into our private package registry so I can mix-in features as needed.

If you don't mind me asking -- have you ever got this working successfully on localhost? It seems that you're unable to add localhost as a replyurl so I used 127.0.0.1 and generated certificates for that for the SSL but still being hit by 403 forbidden.

@FrikkieSnyman
Copy link
Contributor Author

Sheesh it was a long time ago, if I remember correctly, I think I changed my hosts file with a URL to point to 127.0.0.1 and then added that url

@ananay ananay merged commit 1718fb7 into ananay:master Jun 10, 2020
@sameerAhmad9291
Copy link

sameerAhmad9291 commented Aug 11, 2020

Does feature is available in latest package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants