Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic with debug build with big copy length #26

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Fix panic with debug build with big copy length #26

merged 3 commits into from
Mar 11, 2024

Conversation

anatawa12
Copy link
Owner

Fixes #25

@anatawa12
Copy link
Owner Author

As far as I checked entire code, other debug_assert aren't going to fail so I think this makes panic free

@anatawa12 anatawa12 requested a review from NobodyXu March 10, 2024 14:35
@anatawa12 anatawa12 merged commit b4e4b11 into master Mar 11, 2024
6 checks passed
@anatawa12 anatawa12 deleted the issue-25 branch March 11, 2024 04:25
@NobodyXu
Copy link
Collaborator

There's a crate https://lib.rs/crates/no-panic that can help testing that there's no panic in the code (though it requires the related test to be compiled using --release with LTO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"No Enough space" assert (output_window.rs:50) causes panic on invalid (truncated?) input
2 participants
@anatawa12 @NobodyXu