Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary unsafe code #8

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

robjtede
Copy link
Collaborator

@robjtede robjtede commented Aug 13, 2023

There's absolutely no performance win from doing it.

static_literal unwrap   time:   [2.6493 µs 2.6519 µs 2.6549 µs]
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild

static_literal unwrap_unchecked
                        time:   [2.7218 µs 2.7237 µs 2.7255 µs]
Found 6 outliers among 100 measurements (6.00%)
  5 (5.00%) high mild
  1 (1.00%) high severe

static_distance_tree unwrap
                        time:   [552.33 ns 552.96 ns 553.65 ns]
Found 7 outliers among 100 measurements (7.00%)
  5 (5.00%) high mild
  2 (2.00%) high severe

static_distance_tree unwrap_unchecked
                        time:   [623.83 ns 624.40 ns 624.96 ns]
Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) high mild
  1 (1.00%) high severe

@robjtede robjtede marked this pull request as ready for review August 13, 2023 14:17
@robjtede robjtede mentioned this pull request Aug 13, 2023
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@robjtede robjtede merged commit da8e1ad into master Aug 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants