Cr/issue 138 #139
Cr/issue 138 #139
Conversation
|
hmmm. jsperf been down for a while. Makes cross browser profiling and sharing results a bit difficult. Have some results to share, will probably create a few gists. |
| @@ -34,7 +34,7 @@ module.exports = function(d3_scale_linear, d3_time, d3_bisect, techan_util_rebin | |||
| * @returns {*} | |||
| */ | |||
| function scale(x, offset) { | |||
| var mappedIndex = dateIndexMap[+x]; | |||
| var mappedIndex = dateIndexMap[x.getTime ? x.getTime() : +x]; | |||
There was a problem hiding this comment.
Nice catch here, but after profiling I would prefer:
x instanceof Date ? x.getTime() : +xFaster still (for me, linux chrome) and handles undefined and nulls gracefully (without error). I'll add some test cases around the nulls and undefines.
There was a problem hiding this comment.
|
Profile tests: https://gist.github.com/andredumas/7a3277e3cb06c35f4ba34562a873cf35 Thanks for picking this up. As a result will be migrating all the |
|
The
Just because I hate that js uses |
|
static concat dramatically wins, this is good 👍
|
|
Interesting, for me The difference is so huge, I almost think there's something wrong with the test...
|
|
Agree it's not much fun reading those statements, and I'm no performance expert, but it would appear some carefully placed parenthesis and static concat is a winner here. For chrome anyway. I'll make a few mods in techan locally and run the profile again. I'm keen to make crosshairs as responsive as possible and will use the same for other interactions. |
|
Thanks for the contribution @carlos8f |
…string constructor removal, remove Array.join * Adding financetime tests to ensure scale of null and undefined are handled gracefully * Removing String constructor, profiling appears quicker without * Removing usage of Array.join. Array.join is very slow in chrome
fixes issue #138