Use storage access framework #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zidhuss
force-pushed
the
storage-access
branch
from
b55ff77
to
d9981e7
Compare
|
I've tested it on my Pixel 2 running Android 9 and the storage access part seems to work fine. In the process I noticed other quirks though.
|
msfjarvis
force-pushed
the
storage-access
branch
from
d9981e7
to
7435b98
Compare
Merged
msfjarvis
force-pushed
the
storage-access
branch
2 times, most recently
from
5e4d03d
to
7e6409f
Compare
|
Accidentally rebased on local master rather than remote, welp... |
msfjarvis
force-pushed
the
storage-access
branch
from
7e6409f
to
71d58b0
Compare
|
@zidhuss Any blockers? |
|
I've not found time to finish this due to uni commitments (almost done). I'll
be active again from next month. I'd be happy for you to take this on if you'd
like.
…On Sun, Apr 21, 2019 at 03:39:36PM -0700, Harsh Shandilya wrote:
@zidhuss Any blockers?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#469 (comment)
|
I'm down to help. What all's left? Been using it since you opened the PR and haven't had a problem |
|
I'm down to help. What all's left? Been using it since you opened the PR and haven't had a problem
I guess to implement the TODOs:
* https://github.com/zeapo/Android-Password-Store/pull/469/files#diff-c7ecafd98ffa36841d62f01cc006bb68R380 -- We could show the same warning dialog as before.
* https://github.com/zeapo/Android-Password-Store/pull/469/files#diff-c7ecafd98ffa36841d62f01cc006bb68R290 -- This is to ensure that we're importing a correct key so that it doesn't fail later. This one could be a separate pull request.
That's all that's left for now if I remember correctly.
|
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
msfjarvis
force-pushed
the
storage-access
branch
from
71d58b0
to
8c4f8b5
Compare
Done
Gonna leave this for later and start another issue. |
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've now moved up the minimum API level 21, we can make use of the storage access framework. This is going to need some further testing on different devices.
Fixes #391 as you no longer need storage permissions to export passwords or import ssh key.