Treewide codestyle cleanup

[msfjarvis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

I've split the PR up in 3 commits to separate logical parts:

• Updated gitignore and checked in the IDE's codestyle config
• Removed spotless as the underlying ktlint backend has failed to resolve the super frustrating import order bug in nearly a year
• Reformat the entire codebase based on the previously committed code style configuration.

💡 Motivation and Context

The cycle of Write code in the IDE -> Run spotlessApply -> Go back to make a change -> Run spotlessApply again because import order changed got extremely tiring.

💚 How did you test it?

📝 Checklist

• I reviewed submitted code

🔮 Next steps

There seems to be no other formatter available, so none. Might be worth exploring detekt for static analysis.

📸 Screenshots / GIFs

[Skrilltrax]

Wouldn't it be better if we give directions to the UI element ?
IDE shortcuts may not be available if they are used by the system. (I had this issue on KDE)

[msfjarvis]

No way to do that without making the entire thing very wordy. I'm trying to keep this as small as it can be. I intentionally used the wording IntelliJ uses so you can just plop this into a search engine and get the right results should there be a case as yours.

[fmeum]

When I apply the code style to reproduce the reformat of the last commit, I get a non-trivial diff that consists entirely of empty lines after definitions. Is it possible that you have code styles set locally that are not part of the first commit?

[msfjarvis]

When I apply the code style to reproduce the reformat of the last commit, I get a non-trivial diff that consists entirely of empty lines after definitions. Is it possible that you have code styles set locally that are not part of the first commit?

Pretty unlikely, I double checked my settings. As a test I did a manual export of the project settings and replaced the codestyle config in .idea with it. Give that a go?

[fmeum]

Pretty unlikely, I double checked my settings. As a test I did a manual export of the project settings and replaced the codestyle config in .idea with it. Give that a go?

I think that this is caused by KEEP_* settings which make this not 100% reproducible. Maybe we should set BLANK_LINES_AFTER_CLASS_HEADER to 1 to explicitly insert a blank line after class definitions which are implicitly kept by KEEP_BLANK_LINES_IN_DECLARATIONS.

Also I think that even though KEEP_BLANK_LINES_IN_CODE is set to 0 in the checked in settings, not all empty lines in the code have been deleted, e.g.

Android-Password-Store/app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt

Line 197 in 18ebef7

.

[msfjarvis]

Pretty unlikely, I double checked my settings. As a test I did a manual export of the project settings and replaced the codestyle config in .idea with it. Give that a go?

I think that this is caused by KEEP_* settings which make this not 100% reproducible. Maybe we should set BLANK_LINES_AFTER_CLASS_HEADER to 1 to explicitly insert a blank line after class definitions which are implicitly kept by KEEP_BLANK_LINES_IN_DECLARATIONS.

Also I think that even though KEEP_BLANK_LINES_IN_CODE is set to 0 in the checked in settings, not all empty lines in the code have been deleted, e.g.

Android-Password-Store/app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt

Line 197 in 18ebef7

.

Hmm that's wrong yeah. I'll tweak this to make it all more reproducible. Thanks for looking into it!

[msfjarvis]

Alright I *think* this is reproducible now. Wanna give it another try @FabianHenneke @Skrilltrax?

[fmeum]

Yes, this got rid of all the KEEP_* rules.