Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetchat] Add Nested scrolling interop API #837

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

simona-anomis
Copy link
Contributor

Add the Nested scrolling interop API to Jetchat Profile screen, to showcase the proper usage of this experimental API in the scenario of having a View parent and a composable child. Steps done:

  • Refactor ProfileFragment to use an old school XML layout, with a CoordinatorLayout, CollapsingToolbarLayout that hosts a ComposeView for the JetchatAppBar composable and a separate ComposeView that will host the ProfileScreen composable
  • Set the correct Fragment layout and composables using the guidelines on View/Compose interoperability
  • Hook up the nested scrolling interop connection between the View parent and composable childeren via rememberNestedScrollInteropConnection() to enable the collapsing behavior and scrolling connection between all these elements
  • Minor clean up

More elaborate documentation on this coming soon on http://developer.android.com/

@simona-anomis simona-anomis requested a review from a team as a code owner June 6, 2022 10:04
@simona-anomis simona-anomis self-assigned this Jun 6, 2022
@astamato astamato changed the title Add Nested scrolling interop API to Jetchat [Jetchat] Add Nested scrolling interop API Jun 6, 2022
Copy link
Contributor

@astamato astamato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@simona-anomis simona-anomis merged commit e1dccf5 into main Jun 8, 2022
@simona-anomis simona-anomis deleted the ss/jetchat-nested-scroll-interop branch June 8, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants