Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Update to Compose 1.2 snapshot #901

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Conversation

florina-muntenescu
Copy link
Contributor

No description provided.

@@ -34,7 +35,7 @@ buildscript {
}

plugins {
id 'com.diffplug.spotless' version '6.7.0'
id 'com.diffplug.spotless' version '6.5.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you're downgrading?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're upgrading spotless to 6.7.0 but leaving ktlint as it is right now, because of an issue:

pinterest/ktlint#1195

@florina-muntenescu florina-muntenescu merged commit 5fd61ad into 1.2-stable Jul 27, 2022
@florina-muntenescu florina-muntenescu deleted the fm/1.2-stable branch July 27, 2022 14:39
florina-muntenescu added a commit that referenced this pull request Jul 28, 2022
* [All] Update to Compose 1.2 snapshot (#901)

* [All] Update to Compose 1.2 snapshot

* [All] Update to Compose 1.2 snapshot

* [Reply] Updated to Compose 1.2 snapshot

* Upgrade spotless and downgrade ktlint

* Remove unneccessary gradle task for Reply

Co-authored-by: Simona Stojanovic <anomis@google.com>

* [All] Update to Compose 1.2 stable and 1.3.rc01 Compiler

* [All] Update to Compose 1.2 stable and 1.3.rc01 Compiler

* [All] Reverting 1.3.0-rc01 Compiler version

* [Reply, scripts] Addressing PR comments

Co-authored-by: Simona Stojanovic <anomis@google.com>
ataulm pushed a commit to android/wear-os-samples that referenced this pull request Aug 10, 2022
ataulm added a commit to android/wear-os-samples that referenced this pull request Aug 10, 2022
* Fix color space exception

* Bump ktlint

* Downgrade spotless

- revert ktlint bump
- android/compose-samples#901 (comment)
TopDevloper0609 pushed a commit to TopDevloper0609/Wear_os that referenced this pull request Mar 6, 2023
* Fix color space exception

* Bump ktlint

* Downgrade spotless

- revert ktlint bump
- android/compose-samples#901 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants