-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Update to Compose 1.2 snapshot #901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JetNews/build.gradle
Outdated
@@ -34,7 +35,7 @@ buildscript { | |||
} | |||
|
|||
plugins { | |||
id 'com.diffplug.spotless' version '6.7.0' | |||
id 'com.diffplug.spotless' version '6.5.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you're downgrading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're upgrading spotless to 6.7.0 but leaving ktlint as it is right now, because of an issue:
simona-anomis
approved these changes
Jul 27, 2022
florina-muntenescu
added a commit
that referenced
this pull request
Jul 28, 2022
* [All] Update to Compose 1.2 snapshot (#901) * [All] Update to Compose 1.2 snapshot * [All] Update to Compose 1.2 snapshot * [Reply] Updated to Compose 1.2 snapshot * Upgrade spotless and downgrade ktlint * Remove unneccessary gradle task for Reply Co-authored-by: Simona Stojanovic <anomis@google.com> * [All] Update to Compose 1.2 stable and 1.3.rc01 Compiler * [All] Update to Compose 1.2 stable and 1.3.rc01 Compiler * [All] Reverting 1.3.0-rc01 Compiler version * [Reply, scripts] Addressing PR comments Co-authored-by: Simona Stojanovic <anomis@google.com>
ataulm
pushed a commit
to android/wear-os-samples
that referenced
this pull request
Aug 10, 2022
- revert ktlint bump - android/compose-samples#901 (comment)
ataulm
added a commit
to android/wear-os-samples
that referenced
this pull request
Aug 10, 2022
* Fix color space exception * Bump ktlint * Downgrade spotless - revert ktlint bump - android/compose-samples#901 (comment)
TopDevloper0609
pushed a commit
to TopDevloper0609/Wear_os
that referenced
this pull request
Mar 6, 2023
* Fix color space exception * Bump ktlint * Downgrade spotless - revert ktlint bump - android/compose-samples#901 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.