Skip to content

Commit

Permalink
Changed version of typed-ast to fix issue on Appveyor on Python 3.4
Browse files Browse the repository at this point in the history
Details:

* Building the wheel for typed-ast fails with an error that was already
  reported to typed-ast as python/typed_ast#121
  but was decided not to be fixed because the error only showed up on
  Python 3.4 (or only with MSVC 10.0 ?).

  This fix pins the version of typed-ast to <1.4.0 on Python 3.4.

* In addition, typed-ast was missing completely so far from the requirements
  and constraints files, and was added with a minimum version of 1.3.0.

* For Python 3.8 and higher, defined typed-ast verion 1.4.0 as the minimum,
  see issue python/typed_ast#126

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
  • Loading branch information
andy-maier committed Mar 7, 2020
1 parent 4d3aa13 commit 07928ad
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions new_{{ cookiecutter.github_repo }}/dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ pylint>=2.4.4; python_version >= '3.5'
astroid>=1.4.9,<2.0.0; python_version == '2.7'
astroid>=2.1.0,<2.3; python_version == '3.4'
astroid>=2.3.3; python_version >= '3.5'
typed-ast>=1.3.0,<1.4.0; implementation_name == "cpython" and python_version == '3.4'
typed-ast>=1.3.0; implementation_name == "cpython" and python_version >= '3.5' and python_version < '3.8'
typed-ast>=1.4.0; implementation_name == "cpython" and python_version >= '3.8'

# Flake8 (no imports, invoked via flake8 script):
flake8>=3.7.0
Expand Down
2 changes: 2 additions & 0 deletions new_{{ cookiecutter.github_repo }}/minimum-constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ pylint==2.4.4; python_version >= '3.5'
astroid==1.4.9; python_version == '2.7'
astroid==2.1.0; python_version == '3.4'
astroid==2.3.3; python_version >= '3.5'
typed-ast==1.3.0; implementation_name == "cpython" and python_version >= '3.4' and python_version < '3.8'
typed-ast==1.4.0; implementation_name == "cpython" and python_version >= '3.8'

# Flake8 and dependents (no imports, invoked via flake8 script):
flake8==3.7.0
Expand Down

0 comments on commit 07928ad

Please sign in to comment.