rename props

angorayc · Dec 22, 2022 · da58b26 · da58b26
1 parent 26da70b
commit da58b26
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 17 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/alerts_treemap_panel/index.tsx b/x-pack/plugins/security_solution/public/common/components/alerts_treemap_panel/index.tsx
@@ -166,7 +166,7 @@ const AlertsTreemapPanelComponent: React.FC<Props> = ({
     inputId: InputsModelId.global,
     queryId: uniqueQueryId,
   });
-  const alertsOptions = useMemo(
+  const extraVisualizationOptions = useMemo(
     () => ({
       breakdownField: stackByField1,
       showBuildingBlockAlerts,
@@ -231,9 +231,9 @@ const AlertsTreemapPanelComponent: React.FC<Props> = ({
         {isPanelExpanded ? (
           isChartEmbeddablesEnabled && getLensAttributes && timerange ? (
             <LensEmbeddable
-              alertsOptions={alertsOptions}
               data-test-subj="embeddable-matrix-histogram"
               extraActions={extraActions}
+              extraOptions={extraVisualizationOptions}
               getLensAttributes={getLensAttributes}
               height={`${DEFAULT_MIN_CHART_HEIGHT}px`}
               id={uniqueQueryId}

diff --git a/...gins/security_solution/public/common/components/visualization_actions/lens_embeddable.tsx b/...gins/security_solution/public/common/components/visualization_actions/lens_embeddable.tsx
@@ -50,7 +50,7 @@ const initVisualizationData: {
 const style = { height: '100%', minWidth: '100px' };
 
 const LensEmbeddableComponent: React.FC<LensEmbeddableComponentProps> = ({
-  alertsOptions,
+  extraOptions,
   extraActions,
   getLensAttributes,
   height: wrapperHeight,
@@ -69,7 +69,7 @@ const LensEmbeddableComponent: React.FC<LensEmbeddableComponentProps> = ({
   const getGlobalQuery = inputsSelectors.globalQueryByIdSelector();
   const { searchSessionId } = useDeepEqualSelector((state) => getGlobalQuery(state, id));
   const attributes = useLensAttributes({
-    alertsOptions,
+    extraOptions,
     getLensAttributes,
     lensAttributes,
     scopeId,

diff --git a/x-pack/plugins/security_solution/public/common/components/visualization_actions/types.ts b/x-pack/plugins/security_solution/public/common/components/visualization_actions/types.ts
@@ -34,7 +34,7 @@ export interface VisualizationActionsProps {
 }
 
 export interface LensEmbeddableComponentProps {
-  alertsOptions?: AlertsOptions;
+  extraOptions?: AlertsOptions;
   extraActions?: Action[];
   getLensAttributes?: GetLensAttributes;
   height?: string;

diff --git a/.../security_solution/public/common/components/visualization_actions/use_lens_attributes.tsx b/.../security_solution/public/common/components/visualization_actions/use_lens_attributes.tsx
@@ -23,19 +23,19 @@ import {
 } from './utils';
 
 export const useLensAttributes = ({
-  lensAttributes,
+  extraOptions,
   getLensAttributes,
+  lensAttributes,
+  scopeId = SourcererScopeName.default,
   stackByField,
   title,
-  scopeId = SourcererScopeName.default,
-  alertsOptions,
 }: {
-  lensAttributes?: LensAttributes | null;
+  extraOptions?: AlertsOptions;
   getLensAttributes?: GetLensAttributes;
+  lensAttributes?: LensAttributes | null;
+  scopeId?: SourcererScopeName;
   stackByField?: string;
   title?: string;
-  scopeId?: SourcererScopeName;
-  alertsOptions?: AlertsOptions;
 }): LensAttributes | null => {
   const { selectedPatterns, dataViewId, indicesExist } = useSourcererDataView(scopeId);
   const getGlobalQuerySelector = useMemo(() => inputsSelectors.globalQuerySelector(), []);
@@ -76,7 +76,7 @@ export const useLensAttributes = ({
       lensAttributes ??
       ((getLensAttributes &&
         stackByField &&
-        getLensAttributes(stackByField, alertsOptions)) as LensAttributes);
+        getLensAttributes(stackByField, extraOptions)) as LensAttributes);
 
     return {
       ...attrs,
@@ -98,8 +98,8 @@ export const useLensAttributes = ({
       })),
     } as LensAttributes;
   }, [
-    alertsOptions,
     dataViewId,
+    extraOptions,
     filters,
     getLensAttributes,
     indexFilters,

diff --git a/...s/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/index.tsx b/...s/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/index.tsx
@@ -131,7 +131,7 @@ export const AlertsCountPanel = memo<AlertsCountPanelProps>(
       inputId: InputsModelId.global,
       queryId: uniqueQueryId,
     });
-    const alertsOptions = useMemo(
+    const extraVisualizationOptions = useMemo(
       () => ({
         breakdownField: stackByField1,
         showBuildingBlockAlerts,
@@ -232,9 +232,9 @@ export const AlertsCountPanel = memo<AlertsCountPanelProps>(
           {toggleStatus ? (
             isChartEmbeddablesEnabled && getLensAttributes && timerange ? (
               <LensEmbeddable
-                alertsOptions={alertsOptions}
                 data-test-subj="embeddable-matrix-histogram"
                 extraActions={extraActions}
+                extraOptions={extraVisualizationOptions}
                 getLensAttributes={getLensAttributes}
                 height={ChartHeight}
                 id={uniqueQueryId}

diff --git a/...curity_solution/public/detections/components/alerts_kpis/alerts_histogram_panel/index.tsx b/...curity_solution/public/detections/components/alerts_kpis/alerts_histogram_panel/index.tsx
@@ -200,7 +200,7 @@ export const AlertsHistogramPanel = memo<AlertsHistogramPanelProps>(
       inputId: InputsModelId.global,
       queryId: uniqueQueryId,
     });
-    const alertsOptions = useMemo(
+    const extraVisualizationOptions = useMemo(
       () => ({
         showBuildingBlockAlerts,
         showOnlyThreatIndicatorAlerts,
@@ -438,9 +438,9 @@ export const AlertsHistogramPanel = memo<AlertsHistogramPanelProps>(
           {toggleStatus ? (
             isChartEmbeddablesEnabled && getLensAttributes && timerange ? (
               <LensEmbeddable
-                alertsOptions={alertsOptions}
                 data-test-subj="embeddable-matrix-histogram"
                 extraActions={extraActions}
+                extraOptions={extraVisualizationOptions}
                 getLensAttributes={getLensAttributes}
                 height={ChartHeight}
                 id={uniqueQueryId}