Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Do something with uib-dropdown-menu #4753

Closed
Foxandxss opened this issue Oct 28, 2015 · 2 comments
Closed

Do something with uib-dropdown-menu #4753

Foxandxss opened this issue Oct 28, 2015 · 2 comments
Assignees
@Foxandxss
Labels
component: dropdown needs: breaking change type: discussion
Milestone
1.0.0

Comments

@Foxandxss
Copy link
Contributor

I don't like it being a class directive, people gets confused on the consistency of having to prefix that one class or not.

I propose to change it for 1.0.0
@Foxandxss Foxandxss self-assigned this Oct 28, 2015
@Foxandxss Foxandxss added this to the 1.0.0 milestone Oct 28, 2015
@Nieralyte
Copy link

I got confused when came across that prefixed class name. I didn't realize it's a directive, and thought it's just some custom override, and didn't know if i should be prefixing all classes in ui-bootstrap to be consistent.

@wesleycho
Copy link
Contributor

I'm fine with changing it - I think class directives make less sense with the prefixing.

@wesleycho wesleycho mentioned this issue Nov 7, 2015
Closed
8 tasks
@wesleycho wesleycho mentioned this issue Nov 28, 2015
Closed
@icfantv icfantv mentioned this issue Jan 21, 2016
Closed
icfantv added a commit to icfantv/bootstrap that referenced this issue Jan 21, 2016
@icfantv
fix(doc): fix changelog for issue 5186
8eca12b 
* update changelog to indicate bug fix angular-ui#4753.
* update changelog to indicate PR angular-ui#4975.
* update changelog breaking changes to indicate change made.

Fixes angular-ui#5186
@icfantv icfantv mentioned this issue Jan 21, 2016
Closed
icfantv added a commit that referenced this issue Jan 21, 2016
@icfantv
fix(doc): fix changelog for issue 5186
8f94fe8 
* update changelog to indicate bug fix #4753.
* update changelog to indicate PR #4975.
* update changelog breaking changes to indicate change made.

Fixes #5186
Closes #5325
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Foxandxss Foxandxss

Labels
component: dropdown needs: breaking change type: discussion
Projects
None yet
Milestone
1.0.0
4 participants
@icfantv @Foxandxss @wesleycho @Nieralyte