Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Add ability to set templateUrl with uibTimepickerConfig #5087

Closed
40in opened this issue Dec 17, 2015 · 2 comments
Closed

Add ability to set templateUrl with uibTimepickerConfig #5087

40in opened this issue Dec 17, 2015 · 2 comments

Comments

@40in
Copy link

40in commented Dec 17, 2015

new timepicker has uibTimepickerConfig but it doesn't support templateUrl option
It's still possible to set it via attributes, but it would be useful to configure it with standard config

you may check here: http://plnkr.co/edit/Uvw1ECUNK4S6mviz3Qak?p=preview

@wesleycho
Copy link
Contributor

This would be an easy fix if you'd like to file a pull request for this feature - it would need one test to demonstrate that it is possible to override the config and it will use it to fetch a new template. One can use the tests for template-url in any component as a guide to how one would write it.

@deeg
Copy link
Contributor

deeg commented Jan 11, 2016

@wesleycho, are you saying you want the attribute set on the element to override the config if both are set?

I can work on getting a PR out for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants