This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datePicker): Don't parse without date format #2691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under certain conditions, parseDate() is invoked before dateFormat is set. This will cause an error to be thrown.
| @@ -509,6 +509,7 @@ function ($compile, $parse, $document, $position, dateFilter, dateParser, datepi | |||
| ngModel.$setValidity('date', true); | |||
| return viewValue; | |||
| } else if (angular.isString(viewValue)) { | |||
| if (!dateFormat) return null; | |||
There was a problem hiding this comment.
Should initialize var dateFormat = datepickerPopupConfig.datepickerPopup instead.
|
@oliversalzburg See @RobJacobs comments + this no longer merges. |
|
Shocking, given that I wrote the patch half a year ago :p It's a 1-line change. I'm sure @RobJacobs can manage to put his suggestion into the code himself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions, parseDate() is invoked before dateFormat is set.
This will cause an error to be thrown.