Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(modal): pass reason when opened promise rejected #2978

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(modal): pass reason when opened promise rejected
  • Loading branch information
onjiro committed Nov 17, 2014
commit 406fdb5778e82db9c4cc713ba722ff71ffdfa76d
4 changes: 2 additions & 2 deletions src/modal/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,8 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])

templateAndResolvePromise.then(function () {
modalOpenedDeferred.resolve(true);
}, function () {
modalOpenedDeferred.reject(false);
}, function (reason) {
modalOpenedDeferred.reject(reason);
});

return modalInstance;
Expand Down
2 changes: 1 addition & 1 deletion src/modal/test/modal.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ describe('$modal', function () {
ok: function() {return $q.reject('ko');}
}}
);
expect(modal.opened).toBeRejectedWith(false);
expect(modal.opened).toBeRejectedWith('ko');
});

});
Expand Down