-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(@angular/cli): add --location=global flag for Nodejs v16 and later #23772
Conversation
Thanks for this however NPM 14 is still supported. Let's update this when Node.js 14 support is dropped. |
I still maintained the original command and just listed both ways. So v16 could use the new, v14 would still see the old. |
Oops didn't see that. Can you update the commit message as per guidelines https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#commit |
Sure thing.
I’ll update it shortly and resubmit it.
|
@alan-agius4 updated the commit message. |
@estrellajm, I looks like only the PR description was updated. |
Oops! one sec |
Ok, I think I got everything. Updated commit message and PR. |
Can you squash so that there is a single commit please? Thanks. |
@alan-agius4 Ok, I think I got it. Thanks for the help on this. I'll remember these items for my next PR Please let me know if there are any other clean up items that I need to address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your contribution.
The |
@clydin thank you! I just upgraded my npm to v8.15 and can confirm! I must say, this is good news. Closing this PR without merge or further action. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
docs(@angular/cli): add
--location=global
flag for Nodejs v16 and later.When installing @angular/cli with the global flag
-g
for Nodejs v16 and later it throws a warning. Added verbiage to show both flags. Nodejs v14 and older users can continue to use the-g
flag. Nodejs v16 and later users need to use the--location=global
flag.UPDATE: update to README.md.