Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore(scenarioRunner): do not publish updates to bower/npm #9405

Closed
btford opened this issue Oct 3, 2014 · 5 comments · Fixed by #15931
Closed

chore(scenarioRunner): do not publish updates to bower/npm #9405

btford opened this issue Oct 3, 2014 · 5 comments · Fixed by #15931

Comments

@btford
Copy link
Contributor

btford commented Oct 3, 2014

Suggested by @IgorMinar.

Since this has been in "maintenance mode" for a while, it's probably good to start winding down on it and encouraging users to switch to protractor.

@btford btford self-assigned this Oct 3, 2014
@btford btford added this to the Backlog milestone Oct 3, 2014
@wpannell
Copy link

wpannell commented Oct 3, 2014

@IgorMinar Can we still use browserTrigger.js for unit testing directives? I've gotten a lot of value from it for test-driving directives from the outside-in.

@btford
Copy link
Contributor Author

btford commented Oct 3, 2014

@wpannell – I don't see why not

@Narretz
Copy link
Contributor

Narretz commented Oct 9, 2014

When this is done, we can also probably close all issues labeled scenario runner

edit: all those that don't concern browserTrigger, that is

@wpannell
Copy link

@IgorMinar @btford can you comment on the following: my team provided this issue to caution against using browserTrigger.js for directive testing. Not sure I understand the fear of testing our directives the way the AngularJS core team does. Personally, I've always followed those practices closely without incident.

@petebacondarwin
Copy link
Member

@wpannell - while browserTrigger is still only available to external developers via ngScenario, it is perfectly usable.

The point of the comment is that we are not currently providing it in ngMocks as a public function and so you cannot rely on the AngularJS team modifying it to support your own external requirements.

When we finally remove ngScenario we should probably move browserTrigger to ngMocks and then we will have a discussion about what level of support it should get.

@Narretz Narretz assigned Narretz and unassigned btford Feb 14, 2017
@Narretz Narretz modified the milestones: Backlog, 1.7.0 Nov 2, 2017
Narretz added a commit to Narretz/angular.js that referenced this issue Dec 11, 2017
The runner has been deprecated and undocumented since 2014:
See commit 8d6d126899d4b1927360599403a7592011243270

Closes angular#9405
Narretz added a commit to Narretz/angular.js that referenced this issue Dec 13, 2017
The runner has been deprecated and undocumented since 2014:
See commit 8d6d126899d4b1927360599403a7592011243270

Closes angular#9405

BREAKING CHANGE:

The angular scenario runner end-to-end test framework has been
removed from the project and will no longer be available on npm
or bower starting with 1.7.0.
It was deprecated and removed from the documentation in 2014.
Applications that still use it should migrate to
[Protractor](http://www.protractortest.org).
Technically, it should also be possible to continue using an
older version of the scenario runner, as the underlying APIs have
not changed. However, we do not guarantee future compatibility.
Narretz added a commit that referenced this issue Dec 14, 2017
The runner has been deprecated and undocumented since 2014:
See commit 8d6d126899d4b1927360599403a7592011243270

Closes #9405

BREAKING CHANGE:

The angular scenario runner end-to-end test framework has been
removed from the project and will no longer be available on npm
or bower starting with 1.7.0.
It was deprecated and removed from the documentation in 2014.
Applications that still use it should migrate to
[Protractor](http://www.protractortest.org).
Technically, it should also be possible to continue using an
older version of the scenario runner, as the underlying APIs have
not changed. However, we do not guarantee future compatibility.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants