This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
perf(copy): avoid regex in isTypedArray #12054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible for you to share the setup that you are using to check for these performance gains? |
|
Basically something such as f7bf118. Random test snippets within a benchpress app... |
|
LGTM |
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 19, 2015
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 19, 2015
gkalpak
pushed a commit
to gkalpak/angular.js
that referenced
this pull request
Nov 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying and avoiding the regex makes all the copy scenarios I tried 5-15% faster...