Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($compile): evaluate against the correct scope with bindToController on new scope #13025

Closed

Commits on Oct 6, 2015

  1. fix($compile): evaluate against the correct scope with bindToControll…

    …er on new scope
    
    Previously, the directive bindings were evaluated against the directive's
    new (non-isolate) scope, instead of the correct (parent) scope.
    This went unnoticed most of the time, since a property would be eventually
    looked up in the parent scope due to prototypal inheritance. The incorrect
    behaviour was exhibited when a property on the child scope was shadowing
    that on the parent scope.
    
    This commit fixes it.
    
    Fixes angular#13021
    gkalpak committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    677ac40 View commit details
    Browse the repository at this point in the history