Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(): fix scoping for transclusion directives inside replace directive #13244

Merged
merged 4 commits into from
Nov 10, 2015
Merged

fix(): fix scoping for transclusion directives inside replace directive #13244

merged 4 commits into from
Nov 10, 2015

Commits on Nov 10, 2015

  1. fix($compile): fix scoping of transclusion directives inside replace … 

    …directive

Closes angular#12975
Closes angular#12936
Closes angular#13244
    @mzdunek93 @petebacondarwin
    mzdunek93 authored and petebacondarwin committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    1a98c0e View commit details
    Browse the repository at this point in the history

  2. fix($compile): bind all directive controllers correctly when using `b… 

    …indToController`

Previously only the first directive's controller would be bound correctly.

Closes angular#11343
Closes angular#11345
    @jtorbicki @petebacondarwin
    jtorbicki authored and petebacondarwin committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    1c13a4f View commit details
    Browse the repository at this point in the history

  3. fix($compile): evaluate against the correct scope with bindToControll… 

    …er on new scope

Previously, the directive bindings were evaluated against the directive's
new (non-isolate) scope, instead of the correct (parent) scope.
This went unnoticed most of the time, since a property would be eventually
looked up in the parent scope due to prototypal inheritance. The incorrect
behaviour was exhibited when a property on the child scope was shadowing
that on the parent scope.

This commit fixes it.

Fixes angular#13021
Closes angular#13025
    @gkalpak @petebacondarwin
    gkalpak authored and petebacondarwin committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    50557a6 View commit details
    Browse the repository at this point in the history

  4. fix($compile): bind all directive controllers correctly when using `b… 

    …indToController`

Previously only the first directive's controller would be bound correctly.

Closes angular#11343
Closes angular#11345
    @petebacondarwin
    petebacondarwin committed Nov 10, 2015
    5 Configuration menu
    Copy the full SHA
    bd7b217 View commit details
    Browse the repository at this point in the history