Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fix($location): Reset $locaiton.$$replace with every watch call. #1440

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/ng/location.js
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,7 @@ function $LocationProvider(){
var changeCounter = 0;
$rootScope.$watch(function $locationWatch() {
var oldUrl = $browser.url();
var currentReplace = $location.$$replace;

if (!changeCounter || oldUrl != $location.absUrl()) {
changeCounter++;
Expand All @@ -598,12 +599,12 @@ function $LocationProvider(){
defaultPrevented) {
$location.$$parse(oldUrl);
} else {
$browser.url($location.absUrl(), $location.$$replace);
$location.$$replace = false;
$browser.url($location.absUrl(), currentReplace);
afterLocationChange(oldUrl);
}
});
}
$location.$$replace = false;

return changeCounter;
});
Expand Down
15 changes: 15 additions & 0 deletions test/ng/locationSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,21 @@ describe('$location', function() {

expect($browserUrl).toHaveBeenCalledOnce();
expect($browserUrl.mostRecentCall.args).toEqual(['http://new.com/a/b#!/n/url', true]);
expect($location.$$replace).toBe(false);
}));

it('should always reset replace flag after running watch',
inject(function($rootScope, $location, $browser) {

// triggers $evalAsync.
$location.replace();
$rootScope.$apply();
expect($location.$$replace).toBe(false);

// doesn't trigger $evalAsync.
$location.replace();
$rootScope.$apply();
expect($location.$$replace).toBe(false);
}));


Expand Down
13 changes: 4 additions & 9 deletions test/ng/routeSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -560,20 +560,15 @@ describe('$route', function() {
$routeProvider.when('/bar/:id', {templateUrl: 'bar.html'});
$routeProvider.when('/foo/:id/:extra', {redirectTo: '/bar/:id'});
});
inject(function($route, $location, $rootScope) {
var replace;

$rootScope.$on('$locationChangeStart', function(event, newUrl, oldUrl) {
if (oldUrl == 'http://server/#/foo/id3/eId') {
replace = $location.$$replace;
}
});
inject(function($browser, $route, $location, $rootScope) {
var $browserUrl = spyOnlyCallsWithArgs($browser, 'url').andCallThrough();

$location.path('/foo/id3/eId');
$rootScope.$digest();

expect($location.path()).toEqual('/bar/id3');
expect(replace).toBe(true);
expect($browserUrl.mostRecentCall.args)
.toEqual(['http://server/#/bar/id3?extra=eId', true]);
});
});
});
Expand Down